Align pkg/linters spec dependencies with current analyzer surface#36660
Merged
Conversation
3 tasks
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix dependency mismatch in linters package
Align Jun 3, 2026
pkg/linters spec dependencies with current analyzer surface
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pkg/linters package specification to make the documented dependency surface internally consistent with the analyzers described elsewhere in the README.
Changes:
- Expanded
pkg/linters/README.md→## Dependencies→**Internal**to include additional analyzer subpackages (fprintlnsprintf,ossetenvlibrary,uncheckedtypeassertion).
Show a summary per file
| File | Description |
|---|---|
| pkg/linters/README.md | Adds additional internal dependency entries under the ## Dependencies section. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
90
to
+94
| **Internal**: | ||
| - `pkg/linters/errormessage` (via namespace compatibility export `ErrorMessageAnalyzer`). | ||
| - `pkg/linters/fprintlnsprintf` (documented analyzer subpackage). | ||
| - `pkg/linters/ossetenvlibrary` (documented analyzer subpackage). | ||
| - `pkg/linters/uncheckedtypeassertion` (documented analyzer subpackage). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec-librarian audit flagged a cross-package inconsistency in
pkg/linters: the README dependency list did not include all analyzer dependencies it documents elsewhere. This PR updates the package spec so the documented dependency surface is internally consistent.What changed
pkg/linters/README.md→## Dependencies→**Internal**to include missing analyzer dependencies:pkg/linters/fprintlnsprintfpkg/linters/ossetenvlibrarypkg/linters/uncheckedtypeassertionWhy this resolves the audit finding
linters.Spec delta (excerpt)